Move pylint to pre-commit -> faster feedback for devs #4242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Nov 22, 2020
| @@ -34,8 +34,7 @@ disable=all | |||
| # Enable the message, report, category or checker with the given id(s). You can | |||
| # either give multiple identifier separated by comma (,) or put this option | |||
| # multiple time. See also the "--disable" option for examples. | |||
| enable=import-error, | |||
There was a problem hiding this comment.
if pylint runs in an isolated virtualenv, then it won't be able to import third-party modules. However, invalid imports would already raise an error during the pytest jobs, so this check is redundant and can be removed
Codecov Report
@@ Coverage Diff @@
## master #4242 +/- ##
==========================================
+ Coverage 88.11% 88.19% +0.08%
==========================================
Files 87 89 +2
Lines 14243 14358 +115
==========================================
+ Hits 12550 12663 +113
- Misses 1693 1695 +2
|
twiecki
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a dev opens a PR, it can take half an hour for them to see the CI process fail because of some "unused import" error from pylint.
IMO pylint could be moved over to pre-commit, as it can be run in its own isolated environment - this way, devs can get faster feedback if they violate pylint rules. Even if they don't use pre-commit locally, they'll get feedback within 1-2 minutes from the CI job.