-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add release pipeline GitHub Action #3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The steps from the pipeline can be tested in a Docker container:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really helpful, thanks a lot @michaelosthege ! I think the Release Checklist should be updated accordingly.
@michaelosthege sorry for getting back so late on this! I wanted to raise a question - if we want tests to pass before deploy, and for it to deploy only on master, could we get this done instead on Travis? This would make sense, given that Travis is the CI service that is running tests for us. I finally read the Travis docs on how to make it happen, and it looks very similar to how you've defined it using GitHub actions. This weekend I've made some time to dry-run a python package deploy, and can report back. (Sorry for the delay again, I was writing a long notebook on probability, for my own learning, all of the week.) |
@ericmjl No, it doesn't work on travis (took me 4 hours to learn this when trying for I think it's fine that the pipeline doesn't run the tests. We just don't create a Release if the master pipeline is red. Also, we have more pressing worries, like building docs. |
Description
This PR adds a GitHub Action with a release pipeline.
I commented out a few blocks/lines to make the pipeline run on this PR. Which it doesn't, because the GitHub action does not activate before it's on master.
Before merging, the TODO lines (except the tests) MUST be addressed.
Also, a GitHub Action Secret must be created in the Settings of the GitHub repository:
The pipeline currently does not run tests. For now, we must not create release tags if the pipeline failed on master.
TODO
on
condition (will skip the pipeline from the last PR commit before merging, but run it when the release is created)export GITHUB_REF
which is just there to simulate the creation of the release tagPYPI_TOKEN
secret as described abovetwine upload
linepip install pymc3
line to the one that uses the released versionReferences