Skip to content

Add ImputationWarning class. #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

rpgoldman
Copy link
Contributor

The idea is that a programmer be able to ignore imputation warnings if they know that data is being imputed. It's easier to do this with a distinct class than with just UserWarning.

The idea is that a programmer be able to ignore imputation warnings if they know that data is being imputed. It's easier to do this with a distinct class than with just UserWarning.
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #3670 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3670      +/-   ##
==========================================
+ Coverage   89.77%   89.79%   +0.01%     
==========================================
  Files         134      134              
  Lines       20047    20050       +3     
==========================================
+ Hits        17998    18004       +6     
+ Misses       2049     2046       -3
Impacted Files Coverage Δ
pymc3/model.py 87.75% <100%> (+0.01%) ⬆️
pymc3/exceptions.py 100% <100%> (ø) ⬆️
pymc3/distributions/distribution.py 95.32% <0%> (+0.29%) ⬆️
pymc3/step_methods/metropolis.py 87.81% <0%> (+0.31%) ⬆️
pymc3/step_methods/hmc/base_hmc.py 95.32% <0%> (+0.93%) ⬆️

@fonnesbeck
Copy link
Member

Good idea. We should do something similar for the find_MAP warning, which essentially assumes the user is using the function incorrectly.

@lucianopaz lucianopaz merged commit cc55279 into pymc-devs:master Oct 29, 2019
@lucianopaz
Copy link
Member

Great idea! Thanks! If you want, you can do the find_MAP warning in another pr.

@rpgoldman rpgoldman deleted the impute-warning branch October 29, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants