Skip to content

fix issue 3483 where model is not rendered when using sharedvars #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

sidravi1
Copy link
Contributor

Fix for this issue: #3483

@lucianopaz
Copy link
Member

Thanks for the fix, @sidravi1! It looks fine but could you please add a test to test_model_graph.py that asserts that this works as expected and the issue in #3483 is correctly solved?

Another thing, please add a line at the end of the maintenance section of RELEASE-NOTES.md specifying the fix.

Finally, you will have to wait for PR #3485 to get cleaned and merged, and then please rebase the work you did here on top of pymc3/master.

@sidravi1
Copy link
Contributor Author

Hi @lucianopaz - I modified an existing test (let me know if that is a no-no) and merged in changes from PR #3485. Let me know if you need me to do anything

@twiecki
Copy link
Member

twiecki commented May 22, 2019

Some things are showing up in the diff that shouldn't, can you try rebasing?

@sidravi1
Copy link
Contributor Author

Had to fix some of it manually but should be all set now. Files changed only has the two files that i edited in it. (Not sure why it says there is a conflicting file...)

@rpgoldman
Copy link
Contributor

I tried to fix the conflict in the changelog file using the web editor. I've never used that before, and I'm not sure it worked properly.

@rpgoldman
Copy link
Contributor

OK, I think I successfully fixed it up. Probably the history should be tidied by squashing out the merges, etc.

@twiecki
Copy link
Member

twiecki commented May 23, 2019

Seems like the merge was unsuccessful.
image
Either try rebasing or starting a new branch off of master and cherry-picking the appropriate commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants