Fixes to DP mixture notebook #3459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on ReviewNB: https://app.reviewnb.com/pymc-devs/pymc3/pull/3459 Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows. |
|
LGTM. Note that earlier I was talking about the dependent density regression one, however. |
twiecki
added a commit
that referenced
this pull request
May 4, 2019
|
Why was this reverted? The models had not converged in the original version. |
|
I think because it conflicted with the rerun notebooks PR, #3397. Maybe it can be re applied now. |
|
I think the other PR already fixed this NB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DP mixture notebook now runs reasonably well.