Skip to content

changed default values for TruncatedNormal lower and upper from None to -np.inf… #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Mar 26, 2019
Merged

changed default values for TruncatedNormal lower and upper from None to -np.inf… #3250

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
42ffa0d
changed default values for TruncatedNormal lower and upper to -np.inf…
gilliss Nov 13, 2018
51fd1fb
inserted an idea for testing in test_distributions_random.py
gilliss Nov 13, 2018
2e6444b
included a standalone test test_truncated_normal_sample_random_variab…
gilliss Nov 14, 2018
5271433
minor
gilliss Nov 14, 2018
893414f
minor
gilliss Nov 14, 2018
2835086
changed _default value cases in continuous.TruncatedNormal to avoid n…
gilliss Nov 14, 2018
ff5826c
minor
gilliss Nov 14, 2018
590ed88
removed test_truncated_normal_lower from TestScalarParameterSamples s…
gilliss Nov 14, 2018
e9d892c
added TestTruncatedNormalUpper and addressed TruncatedNormal _normali…
gilliss Nov 14, 2018
05b5c4c
changed TruncatedNormal.logp to check for infs instead of Nones
gilliss Nov 15, 2018
68dae58
debugging
gilliss Nov 15, 2018
7d03359
debugging
gilliss Nov 15, 2018
a58e8cb
debugging
gilliss Nov 15, 2018
ae90f8f
debugging
gilliss Nov 15, 2018
8ea31bf
debugging
gilliss Nov 15, 2018
77a0e8c
debugging
gilliss Nov 15, 2018
af89cba
tried np.isinf and put in the requested test_truncated_normal_lower t…
gilliss Nov 30, 2018
3febdd3
added extra members self.lower_np self.upper_np for checking values
gilliss Jan 4, 2019
343b6d0
changed to upper_check and lower_check members, with None checks
gilliss Jan 4, 2019
f08299f
minor
gilliss Jan 4, 2019
2d60f58
merged upstream/master
gilliss Jan 4, 2019
d68a640
merged from my own dev branch
gilliss Jan 4, 2019
def32d3
minor
gilliss Jan 4, 2019
8016105
minor
gilliss Jan 4, 2019
1e0c6aa
minor
gilliss Jan 4, 2019
b18623b
removed corresponding paramdomains from upper and lower tests
gilliss Jan 5, 2019
3e1dcf6
Merge branch 'master' of https://github.com/pymc-devs/pymc3
Mar 25, 2019
2cd14ab
removed upper positional arg from test_truncated_normal_lower and vic…
Mar 25, 2019
303843f
Update pymc3/tests/test_distributions_random.py
twiecki Mar 26, 2019
dd9d2f6
Update pymc3/tests/test_distributions_random.py
twiecki Mar 26, 2019
ae73bc0
Update pymc3/tests/test_distributions_random.py
twiecki Mar 26, 2019
2146664
Update pymc3/tests/test_distributions_random.py
twiecki Mar 26, 2019
2c3d1e2
minor syntax
Mar 26, 2019
a63961f
added line to docs/release-notes/pymc3-3.0.md
Mar 26, 2019
a60bbd0
moved release notes line to RELEASE-NOTES.md
Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pymc3/distributions/continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,15 +575,15 @@ def __init__(self, mu=0, sd=None, tau=None, lower=None, upper=None,
tau, sd = get_tau_sd(tau=tau, sd=sd)
self.sd = tt.as_tensor_variable(sd)
self.tau = tt.as_tensor_variable(tau)
self.lower = tt.as_tensor_variable(lower) if lower is not None else lower
self.upper = tt.as_tensor_variable(upper) if upper is not None else upper
self.lower = tt.as_tensor_variable(lower) if lower is not None else -np.inf
self.upper = tt.as_tensor_variable(upper) if upper is not None else np.inf
self.mu = tt.as_tensor_variable(mu)

if self.lower is None and self.upper is None:
if tt.isinf(self.lower) and tt.isinf(self.upper):
self._defaultval = mu
elif self.lower is None and self.upper is not None:
elif tt.isinf(self.lower) and not tt.isinf(self.upper):
self._defaultval = self.upper - 1.
elif self.lower is not None and self.upper is None:
elif not tt.isinf(self.lower) and tt.isinf(self.upper):
self._defaultval = self.lower + 1.
else:
self._defaultval = (self.lower + self.upper) / 2
Expand Down
5 changes: 4 additions & 1 deletion pymc3/tests/test_distributions_random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,10 @@ class TestTruncatedNormal(BaseTestCases.BaseTestCase):
distribution = pm.TruncatedNormal
params = {'mu': 0., 'tau': 1., 'lower':-0.5, 'upper':0.5}

class TestTruncatedNormalLower(BaseTestCases.BaseTestCase):
distribution = pm.TruncatedNormal
params = {'mu': 0., 'tau': 1., 'lower':-0.5}

class TestSkewNormal(BaseTestCases.BaseTestCase):
distribution = pm.SkewNormal
params = {'mu': 0., 'sd': 1., 'alpha': 5.}
Expand Down Expand Up @@ -419,7 +423,6 @@ def ref_rand(size, tau):
def test_uniform(self):
def ref_rand(size, lower, upper):
return st.uniform.rvs(size=size, loc=lower, scale=upper - lower)

pymc3_random(pm.Uniform, {'lower': -Rplus, 'upper': Rplus}, ref_rand=ref_rand)

def test_normal(self):
Expand Down