Improve random for ObservedRV #3036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To generate random array for ObservedRV in sample_ppc and sample_prior_predictive a shape kwarg sometimes is needed to make sure the generated array has the same shape as the observed. This PR improved that to make sure the shape is inferred during random number generation. Previously I tried to add the shape attr to ObservedRV at the model creation, but turns out it breaks the sample_ppc for theano.shared observation. I try a different approach here to always reset the distribution shape at generation.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To generate random array for ObservedRV in
sample_ppcandsample_prior_predictiveashapekwarg sometimes is needed to make sure the generated array has the same shape as the observed.This PR improved that to make sure the shape is inferred during random number generation.
Previously I tried to add the shape attr to
ObservedRVat the model creation, but turns out it breaks thesample_ppcfortheano.sharedobservation. I try a different approach here to always reset the distribution shape at generation.