Skip to content

Update hierarchical partial pooling notebook #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

aseyboldt
Copy link
Member

@aseyboldt aseyboldt commented Jun 9, 2017

I fixed another notebook. Then I noticed that it hadn't been broken in the first place.
Still, I improved mixing by switching around the parametrization a bit and updated the api usage.

@aseyboldt
Copy link
Member Author

CC @ColCarroll That was yours, right?

@fonnesbeck
Copy link
Member

A nitpick, but I would move the paragraph-long comment in cell 3 out into its own markdown cell. You can even break down the model specification into 2 with blocks to help step through the model construction.

@ColCarroll
Copy link
Member

Not mine -- I think this was @usptact. I did an API fix and some proofreading though. Looks fine to me!

@usptact
Copy link
Contributor

usptact commented Jun 13, 2017

Yes, I created this notebook. Is there something I need to change?

@ColCarroll
Copy link
Member

ColCarroll commented Jun 13, 2017 via email

@usptact
Copy link
Contributor

usptact commented Jun 13, 2017

@ColCarroll Thanks! It would be much more difficult without help of @twiecki and @fonnesbeck !

Currently I work more with Infer.NET (due to the platform) but I check out regularly what are you guys doing with PyMC3!

Cheers!

@fonnesbeck
Copy link
Member

Thanks again @usptact

@junpenglao
Copy link
Member

This is ready to merge right? @aseyboldt

@aseyboldt aseyboldt force-pushed the fix-hier-part-pool branch from 202e6e5 to a8c9481 Compare July 7, 2017 09:51
@aseyboldt
Copy link
Member Author

Now it is. I moved the long comment into a paragraph.

@junpenglao junpenglao merged commit d4ba0c4 into pymc-devs:master Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants