Skip to content

WIP: Enhancing inference docs #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: Enhancing inference docs #1969

wants to merge 1 commit into from

Conversation

springcoil
Copy link
Contributor

Based on #1968 I updated some of the ADVI docs.

Some more work needs done.

@aseyboldt
Copy link
Member

I think it makes sense to split this into two pages: One about MCMC, and one about variational methods. We could then start both pages with a few sentences about what they do. I don't know that much about variational methods, but how about something like this (suggestions welcome):

"Variational methods approximate the posterior by looking at a finite dimensional subspaces of the set of possible posterior distributions. They try to find an element of this subspace that is similar to the actual posterior. While they tend to be much faster than Monte Carlo sampling, they are limited by the choice of subspace. Posteriors that are very different from all posteriors in the subset can not be approximated reasonably."

After than a table of the most important functions (not sure myself...):

.. currentmodule:: pymc3.variational

.. autosummary::
   
   fit
   ADVI
   FullRankADVI
   advi 

After that the api of the individual modules.

@@ -55,6 +55,13 @@ ADVI

.. currentmodule:: pymc3.variational.advi

.. autosummary::

TestFunction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't in pymc3.variational.advi, but in pymc3.variational.inference, so this doesn't work.

:members:

SVGD
^^^^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the methods here have a docstring, so nothing shows up in the doc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ferrine has re-implemented these in OPVI, so we can probably drop SVGD for now.

@springcoil
Copy link
Contributor Author

springcoil commented Mar 30, 2017 via email

@springcoil
Copy link
Contributor Author

springcoil commented Apr 7, 2017

I'll try to get to this again this weekend. I'll agree that there's some changes and this has to be changed. I was hoping to just get the placeholders in there so docstrings can be added in later.

@springcoil springcoil changed the title Enhancing inference docs WIP: Enhancing inference docs Apr 7, 2017
@junpenglao
Copy link
Member

Close in favor of the new VI docs. Thanks of the effort @springcoil

@junpenglao junpenglao closed this Jul 10, 2017
@junpenglao junpenglao deleted the advi_docs branch July 10, 2017 08:25
@springcoil
Copy link
Contributor Author

springcoil commented Jul 10, 2017 via email

@junpenglao
Copy link
Member

I know that feel - There are just too many fun stuff we want to do but also many (less fun) stuff we had to do ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants