-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adding hierarhical partial pooling example #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @usptact, that's very useful. Even cooler would be the model with a bit more description and plots in form of an ipython notebook, similar to what we have here: http://pymc-devs.github.io/pymc3/examples.html It will also get more recognition there. Let me know if you want to do that, otherwise I'm happy to merge this. |
@twiecki Thanks! Definitely some informative plots (and debugging?) would be very useful. Would you point me to resources/examples where such plots are available? I would be happy to add them to the script. |
Maybe check out the examples in: https://github.com/pymc-devs/pymc3/tree/master/docs/source/notebooks Use Jupyter Notebook to create a small tutorial on the model (does not have to be as detailed as the original of course). |
@twiecki I've added the IPython notebook. As I am pretty new to Bayesian modeling and notebooks, please let me know what needs to be improved. |
@twiecki Is there anything that prevents from merging in this notebook? I would be glad to improve it further. |
We already have a few hierarchical examples. I'm not opposed to adding another as long as it brought something new to the example set. Let me have a look at it and see if I can offer any suggestions. |
@fonnesbeck One, possible minor contribution, is demonstrating how to put lower/upper bounds on variables. I didn't find that in any of the examples and had to dig it out from documentation and source code. |
@usptact Please check out this revision I've cleaned up the grammar and focused the narrative a bit, including providing the answer to the original question: what is the likely batting average of the 0-for-4 player. See what you think. |
@fonnesbeck Great work! This reminds me countless iterations with my PhD advisor on papers and thesis! I love how you re-purposed the subject "what is performance for a 0 hits from 4 at-bats" player while keeping the application in context. |
Great, why dont you download my Gist and drop it in as a replacement in your PR, then I can merge it. |
credits: Chris Fonnesback
@fonnesbeck I added the notebook to this pull request. |
Credits:
http://mc-stan.org/documentation/case-studies/pool-binary-trials.html