Skip to content

Adding hierarhical partial pooling example #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2016
Merged

Adding hierarhical partial pooling example #1546

merged 3 commits into from
Dec 1, 2016

Conversation

usptact
Copy link
Contributor

@usptact usptact commented Nov 22, 2016

@twiecki
Copy link
Member

twiecki commented Nov 22, 2016

Thanks @usptact, that's very useful. Even cooler would be the model with a bit more description and plots in form of an ipython notebook, similar to what we have here: http://pymc-devs.github.io/pymc3/examples.html It will also get more recognition there. Let me know if you want to do that, otherwise I'm happy to merge this.

@usptact
Copy link
Contributor Author

usptact commented Nov 22, 2016

@twiecki Thanks! Definitely some informative plots (and debugging?) would be very useful. Would you point me to resources/examples where such plots are available? I would be happy to add them to the script.

@twiecki
Copy link
Member

twiecki commented Nov 23, 2016

Maybe check out the examples in: https://github.com/pymc-devs/pymc3/tree/master/docs/source/notebooks

Use Jupyter Notebook to create a small tutorial on the model (does not have to be as detailed as the original of course).

@usptact
Copy link
Contributor Author

usptact commented Nov 26, 2016

@twiecki I've added the IPython notebook. As I am pretty new to Bayesian modeling and notebooks, please let me know what needs to be improved.

@usptact
Copy link
Contributor Author

usptact commented Nov 28, 2016

@twiecki Is there anything that prevents from merging in this notebook? I would be glad to improve it further.

@fonnesbeck
Copy link
Member

We already have a few hierarchical examples. I'm not opposed to adding another as long as it brought something new to the example set. Let me have a look at it and see if I can offer any suggestions.

@usptact
Copy link
Contributor Author

usptact commented Nov 28, 2016

@fonnesbeck One, possible minor contribution, is demonstrating how to put lower/upper bounds on variables. I didn't find that in any of the examples and had to dig it out from documentation and source code.

@fonnesbeck
Copy link
Member

@usptact Please check out this revision I've cleaned up the grammar and focused the narrative a bit, including providing the answer to the original question: what is the likely batting average of the 0-for-4 player. See what you think.

@usptact
Copy link
Contributor Author

usptact commented Nov 30, 2016

@fonnesbeck Great work! This reminds me countless iterations with my PhD advisor on papers and thesis! I love how you re-purposed the subject "what is performance for a 0 hits from 4 at-bats" player while keeping the application in context.
Thanks also for the plots, I was not certain what information to pull out and how to do it with matplotlib.

@fonnesbeck
Copy link
Member

Great, why dont you download my Gist and drop it in as a replacement in your PR, then I can merge it.

@usptact
Copy link
Contributor Author

usptact commented Dec 1, 2016

@fonnesbeck I added the notebook to this pull request.

@fonnesbeck fonnesbeck merged commit 010de60 into pymc-devs:master Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants