-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Proposal: Dist shape refactor #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5696ed4
initial fix of shape logic in MvNormal
brandonwillard 1571255
initial signature/interface changes
brandonwillard 02696f7
initial distribution shape refactoring
brandonwillard b1d4cee
major fixes and small Theano random example comments
brandonwillard 6b47c64
fixed (some) handling of symbolic scalar shapes
brandonwillard 69c6ffe
initial distribution shape refactoring
brandonwillard 9f99178
fixed (some) handling of symbolic scalar shapes
brandonwillard 9563d8a
started splitting up dist. classes; some small testval test changes
brandonwillard e6e1b4a
forced derived shape components to be tuples
brandonwillard a8b26ec
fixed typos from rebase
brandonwillard 72e025e
removed unnecessary shape args in univariates; added check and shape …
brandonwillard c8a578c
fixed some shape issues in transform and advi logic
brandonwillard 30133e1
started shape handling updates for missing data
brandonwillard 842277c
refactored discrete dist. constructors; added support for (depricated…
brandonwillard 19497d4
fixes to univariate shape determination; typo fixes in multivatiate (…
brandonwillard 56d9a1e
fixed test_value replications issue
brandonwillard e702da1
fixed another broadcasting issue; started updating tests
brandonwillard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_value
was returning a primitive (not a numpy array) in the tests. Not sure if that's due to another issue, yet; still clearing out the big issues following the evaluation hack I just added. Will comment on all this once the tests are passing again (or sooner, if necessary).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, was just curious. Great to see you picking this back up!