Skip to content

Make mypy precommit script easier to understand #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
canyon289 opened this issue Apr 3, 2022 · 2 comments
Closed

Make mypy precommit script easier to understand #5685

canyon289 opened this issue Apr 3, 2022 · 2 comments

Comments

@canyon289
Copy link
Member

Description of your problem

The mypy output on failure is dense and hard to read. It would benefit from improvements to smooth development workflow

Ideas

  • Break apart failures that are preexisting, versus the ones introduced last commit
  • Make the output easier to read by segmenting by file more cleanly than the massive wall of text right now such as
    • Split errors from notes
    • Format the output so the error is more readable, right now its a mix of single or multi line so its hard to discern easily where one starts and the other ends

The output is a dataframe that can be easily iterated over and worked with.

Script is here
https://github.com/pymc-devs/pymc/blob/741d45540016ab52a15ad5bff521614b6ae1d835/scripts/run_mypy.py

@soma2000-lang
Copy link
Contributor

@canyon289 I am new to solving this kind of issue/It would be great if you can me get started

@canyon289
Copy link
Member Author

If youre totally new to contributing Id suggest this issue which is closer to the main line codebase. if youre definitely sure youd ilke to work on this issue, the idea would be to format the output to be easier to read

#5729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants