Skip to content

Upgrade Aesara and NumPy upper version limits #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelosthege opened this issue Jan 7, 2022 · 2 comments · Fixed by #5369
Closed

Upgrade Aesara and NumPy upper version limits #5321

michaelosthege opened this issue Jan 7, 2022 · 2 comments · Fixed by #5369

Comments

@michaelosthege
Copy link
Member

Aesara is currently pinned and can't be updated to the latest version until aesara-devs/aesara#707 is fixed.

That means we also don't get the NumPy 1.22 compatibility fix until we can upgrade.

Until that Aesara upgrade we'll want to pin numpy<1.22.0 and keep this issue open until we can upgrade Aesara and remove the NumPy version pin.

For stability, we should still pin Aesara at the minor, or even the patch version.

@michaelosthege michaelosthege added this to the v4.0.0b2 milestone Jan 7, 2022
michaelosthege added a commit that referenced this issue Jan 10, 2022
@michaelosthege michaelosthege modified the milestones: v4.0.0b2, v4.0.0b3 Jan 10, 2022
twiecki pushed a commit that referenced this issue Jan 10, 2022
@twiecki
Copy link
Member

twiecki commented Jan 18, 2022

aesara-devs/aesara#707 is fixed now and has an aesara release 2.3.5 https://github.com/aesara-devs/aesara/releases/tag/rel-2.3.5 which we should pin.

@twiecki
Copy link
Member

twiecki commented Jan 20, 2022

We should cut a new release. CC @michaelosthege

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants