-
-
Notifications
You must be signed in to change notification settings - Fork 752
Rethinking 2 - Chapter 5 Edits #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
constrained priors in order to allow sampler to run
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@yahrMason thanks for doing this. Is this the only notebook that is upgraded to PyMC v4? Two quetsions as well
|
@canyon289 from what I can tell, it looks like all of the notebooks under Rethinking2 have been converted to PyMC v4. As for your two questions, I certainly can change the env file. Is that as simple as just changing "pymc3" to "pymc"? And yes, I intend to convert all of them as I progress through the text. Should I open a single PR for this initiative and commit as I go along? I wasn't sure what the right approach was. Thank you for your patience with me. Two of my goals this year are to learn more about Bayesian statistics and to contribute to open source. I thought this looked like a good exercise to get experience in both of those areas. I am still early in my learning journey. |
Thanks so much! What I would suggest right now is creating a second If you're going through the book checking the other notebooks will be a great way to learn as well. As for this PR the precommit failed. Please run the isort and nblack commands to ensure all the formatting is correct. Thanks much for the PR! |
@yahrMason Thanks for the edits, it really helped. |
createing yml file for stat-rethink2-pymc_v4 environment
It is my understanding that pymc v4 no longer has a dependency on theano, but I did not want to remove that without confirming. I have frozen the package version for theano-pymc but can remove if that is desired
@EAly you are right, the rest of the notebooks have not been updated. My apologies. What I meant was that the "import pymc3 as pm" statements have all been changed to "import pymc as pm" in the notebooks. This will cause all of them to have issues. I am working through them all to change them. I will open PRs for them as I progress. |
Thank you! |
Thank you for opening a pull request!
Please check our style guide, and also make sure that the notebooks you've modified pass the
pre-commit
checks. If, for example, you modifiednotebook1.ipynb
andnotebook2.ipynb
, you could do this by running:You may need to run it a couple of times before all the checks pass.