Skip to content

Rethinking 2 - Chapter 5 Edits #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 21, 2022
Merged

Conversation

yahrMason
Copy link
Contributor

Thank you for opening a pull request!

Please check our style guide, and also make sure that the notebooks you've modified pass the pre-commit checks. If, for example, you modified notebook1.ipynb and notebook2.ipynb, you could do this by running:

pre-commit run --files notebook1.ipynb notebook2.ipynb

You may need to run it a couple of times before all the checks pass.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@canyon289
Copy link
Member

@yahrMason thanks for doing this. Is this the only notebook that is upgraded to PyMC v4? Two quetsions as well

  • Are you planning on changing the env file
  • Just curious are you planning on updating the rest of the notebooks as well

@yahrMason
Copy link
Contributor Author

@canyon289 from what I can tell, it looks like all of the notebooks under Rethinking2 have been converted to PyMC v4. As for your two questions, I certainly can change the env file. Is that as simple as just changing "pymc3" to "pymc"? And yes, I intend to convert all of them as I progress through the text. Should I open a single PR for this initiative and commit as I go along? I wasn't sure what the right approach was.

Thank you for your patience with me. Two of my goals this year are to learn more about Bayesian statistics and to contribute to open source. I thought this looked like a good exercise to get experience in both of those areas. I am still early in my learning journey.

@canyon289
Copy link
Member

certainly can change the env file. Is that as simple as just changing "pymc3" to "pymc"?

Thanks so much! What I would suggest right now is creating a second environment.yml file labeled environment_v4.yml while were switching from v3 to v4. I would make it the versions of all the packages youre using right now, This will be more than just v4 as the aesara and aeppl versions will ned to be changed as well.

If you're going through the book checking the other notebooks will be a great way to learn as well.

As for this PR the precommit failed. Please run the isort and nblack commands to ensure all the formatting is correct. Thanks much for the PR!

@EAly
Copy link

EAly commented Jul 19, 2022

@yahrMason Thanks for the edits, it really helped.
I'm not sure, however, that all of the notebooks under Rethinking2 have been converted to PyMC v4.

createing yml file for stat-rethink2-pymc_v4 environment
It is my understanding that pymc v4 no longer has a dependency on theano, but I did not want to remove that without confirming. I have frozen the package version for theano-pymc but can remove if that is desired
@yahrMason
Copy link
Contributor Author

@EAly you are right, the rest of the notebooks have not been updated. My apologies. What I meant was that the "import pymc3 as pm" statements have all been changed to "import pymc as pm" in the notebooks. This will cause all of them to have issues. I am working through them all to change them. I will open PRs for them as I progress.

@canyon289
Copy link
Member

Thank you!

@canyon289 canyon289 merged commit 1c63d6c into pymc-devs:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants