Skip to content

add default to argument to prior util #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023
Merged

add default to argument to prior util #93

merged 2 commits into from
May 24, 2023

Conversation

ferrine
Copy link
Member

@ferrine ferrine commented Nov 18, 2022

No description provided.

@ferrine
Copy link
Member Author

ferrine commented Nov 21, 2022

@ricardoV94 this one is ready, feel free to merge if looks good to you

@ricardoV94
Copy link
Member

What's the point of calling this function with an empty model?

@ferrine
Copy link
Member Author

ferrine commented May 23, 2023

What's the point of calling this function with an empty model?

if you pass everything to kwargs for example, the API supports inspecting the passed kwargs, in a lot of cases it is easier to just use kwargs

@ricardoV94
Copy link
Member

Will this function ever do anything with empty var_names?

@ferrine
Copy link
Member Author

ferrine commented May 23, 2023

Will this function ever do anything with empty var_names?

kwargs + var_names combined matter, not just var_names

@ricardoV94
Copy link
Member

ricardoV94 commented May 23, 2023

Will this function ever do anything with empty var_names?

kwargs + var_names combined matter, not just var_names

So why this change to allow kwargs + no var_names? If that case can only end up with an empty dictionary?

@ferrine
Copy link
Member Author

ferrine commented May 23, 2023

Will this function ever do anything with empty var_names?

kwargs + var_names combined matter, not just var_names

So why this change to allow kwargs + no var_names? If that case can only end up with an empty dictionary?

he change is required to use the function with kwargs only

@ferrine ferrine merged commit f9d1c55 into main May 24, 2023
@ferrine ferrine deleted the fix-priors-api branch May 24, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants