Fix bug in fit_MAP when shared variables are used in graph
#468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndorra
approved these changes
May 2, 2025
ricardoV94
approved these changes
May 2, 2025
| if use_jax_gradients: | ||
| from pymc.sampling.jax import _replace_shared_variables | ||
|
|
||
| [loss] = _replace_shared_variables([loss]) |
There was a problem hiding this comment.
btw this is the sort of stuff that can lead to big constant foldings in JAX
jessegrabowski
force-pushed
the
shared-vars-map-jax
branch
from
0d5c33c to
f1bb479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
fit_MAPfails on graphs with shared variables whengradient_backend='jax'. This is because we are discarding the pytensor function wrapper that helps work with them. This PR rewrites shared variables into constants using_replace_shared_variablesin this case. This is the same approach used inpymc.sampling.jax.get_jaxified_graph