Refactor alpha_recover and inverse_hessian_factors to remove update_m… #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphc14
force-pushed
the
pf-speedup-hessian-calcs
branch
from
1cc9962 to
f08a40f
Compare
…ask parameter - Removed the update_mask variable from alpha_recover and inverse_hessian_factors functions. - Simplified the logic in alpha_recover by directly computing alpha without filtering updates. - Changes should offer speed-ups by reducing reliance on scan functions, and perform vectorised operations.
- Corrected the condition for LOW_UPDATE_PCT in LBFGS status handling. - Removed update_mask references in alpha_recover and inverse_hessian_factors - Adjusted test cases to reflect changes in status messages and function signatures.
|
Can we include this in the 0.2.5 release if it passes all checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a working draft to modify
alpha_recoverandinverse_hessian_factorsfunctions.Following changes by #461, the LBFGS history array,
x,g, should be a filtered array using the same conditions previously set byupdate_mask. Therefore, removing the need forupdate_maskinalpha_recoverandinverse_hessian_factors, andpytensor.scanininverse_hessian_factors.