Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the following fixes:
_validate_data
method is called forpredict_posterior
method, but notpredict
method. Should be called in both as the only difference between the two should be whether mean or full posterior samples are returned.self.is_fitted_ = False
set in class init, but not set toTrue
when model is fitted withfit
. Decided to keep the variable as it is useful, therefore set toTrue
after 1)fit
called 2)load
with fitted data.The alternative is to remove
self.is_fitted_
altogether, seeing as the other functions tend to check for fitting via the existence of inference data (model.idata
) instead. Alternatively, could refactor these checks to instead useis_fitted_
.