Fix math in sigma attachment #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
approved these changes
Jul 4, 2023
ferrine
force-pushed
the
fix-sigma-attachment-math
branch
from
c41f7cd to
d6ca4a1
Compare
When reparametrizing sigma into explained variance + resigual sigma, tau is not needed any more, but was mistakenly used in the model that lead to instabilities and incorrect interpretation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reparametrizing sigma into explained variance + residual sigma, tau is not needed any more, but was mistakenly used in the model that led to instabilities and incorrect interpretation.
Related to #206