Skip to content

storing model_config and sampler_config changed to json string #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions pymc_experimental/model_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@


import hashlib
import json
from pathlib import Path
from typing import Dict, Union

Expand Down Expand Up @@ -187,8 +188,8 @@ def load(cls, fname):
filepath = Path(str(fname))
idata = az.from_netcdf(filepath)
self = cls(
dict(zip(idata.attrs["model_config_keys"], idata.attrs["model_config_values"])),
dict(zip(idata.attrs["sample_config_keys"], idata.attrs["sample_config_values"])),
json.loads(idata.attrs["model_config"]),
json.loads(idata.attrs["sampler_config"]),
idata.fit_data.to_dataframe(),
)
self.idata = idata
Expand Down Expand Up @@ -237,10 +238,8 @@ def fit(self, data: Dict[str, Union[np.ndarray, pd.DataFrame, pd.Series]] = None
self.idata.attrs["id"] = self.id
self.idata.attrs["model_type"] = self._model_type
self.idata.attrs["version"] = self.version
self.idata.attrs["sample_config_keys"] = tuple(self.sample_config.keys())
self.idata.attrs["sample_config_values"] = tuple(self.sample_config.values())
self.idata.attrs["model_config_keys"] = tuple(self.model_config.keys())
self.idata.attrs["model_config_values"] = tuple(self.model_config.values())
self.idata.attrs["sampler_config"] = json.dumps(self.sample_config)
self.idata.attrs["model_config"] = json.dumps(self.model_config)
self.idata.add_groups(fit_data=self.data.to_xarray())
return self.idata

Expand Down