Skip to content

use dict instead of treedict in marginalized model #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ferrine opened this issue Dec 26, 2023 · 1 comment · Fixed by #293
Closed

use dict instead of treedict in marginalized model #291

ferrine opened this issue Dec 26, 2023 · 1 comment · Fixed by #293

Comments

@ferrine
Copy link
Member

ferrine commented Dec 26, 2023 •
edited
Loading

Treedict was intended for nested usecase, where there are submodels like in https://github.com/pymc-devs/pymc/blob/main/pymc/model/core.py#L529, https://github.com/pymc-devs/pymc/blob/main/pymc/model/core.py#L478 . But marginalized model is not supposed to be used like that, so the functionality can be removed and simplified

https://github.com/pymc-devs/pymc-experimental/blob/4f75687346cb67cfb794dad00bc2cac52066a8b7/pymc_experimental/model/marginal_model.py#L17
zaxtax added a commit to zaxtax/pymc-experimental that referenced this issue Jan 1, 2024
@zaxtax
Remove use of treedict, addresses pymc-devs#291
d366e12
@zaxtax
Copy link
Contributor

zaxtax commented Jan 1, 2024

I can't remove the use of treedict for named_vars since it is expected to be a treedict https://github.com/pymc-devs/pymc/blob/main/pymc/model/core.py#L1427

@ricardoV94 ricardoV94 mentioned this issue Jan 1, 2024
Merged
ricardoV94 pushed a commit that referenced this issue Jan 1, 2024
@zaxtax @ricardoV94
Remove use of treedict, addresses #291
953cb7f
xieyj17 pushed a commit to xieyj17/pymc-experimental that referenced this issue Jan 1, 2024
@zaxtax @xieyj17
Remove use of treedict, addresses pymc-devs#291
22a3b0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of treedict, addresses #291 zaxtax/pymc-experimental
2 participants
@zaxtax @ferrine