Fixup dependent density regression #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MarcoGorelli
force-pushed
the
fixup-dependent-density-regression
branch
from
f987090 to
a4bbf5d
Compare
|
Is this ready for review? |
|
Sure! EDITActually, maybe a graphviz graph is helpful here |
MarcoGorelli
force-pushed
the
fixup-dependent-density-regression
branch
from
7cbf7aa to
6a2e2d0
Compare
MarcoGorelli
force-pushed
the
fixup-dependent-density-regression
branch
from
6a2e2d0 to
2a580a9
Compare
|
@AlexAndorra ready now, thanks! |
AlexAndorra
reviewed
Dec 19, 2020
| @@ -2,7 +2,16 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
This is fine, but for future reference I think you could do the handling on w directly with xarray (makes it even nicer and easier!): http://xarray.pydata.org/en/stable/computation.html
Reply via ReviewNB
There was a problem hiding this comment.
ah, thanks! OK I'll do that next time
AlexAndorra
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Dependent density regression notebook' currently doesn't run (the data doesn't download, and the plot of the posterior predictive throws an error) so here's a PR to fix it up.
Furthermore, the notebook previously read
yet the posterior plot only showed two mixture components having appreciable posterior expected weight for any data point. With the current re-run, it looks right