-
-
Notifications
You must be signed in to change notification settings - Fork 269
Fix Broken Link in Weibull Accelerated Failure Time Model Notebook #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks so much for opening this PR. Can you check out this section of the Jupyter style guide, because I think that's how the link needs to be fixed. If the notebook that needs to be linked to doesn't have the Let me know if that's unclear (it may be). |
Thanks so much for your guidance! I apologise for the oversight. I've now updated the link in the Weibull notebook using {ref} as suggested and added the required (bayes_param_survival_pymc3)= attribute to the target notebook. I wasn't able to check this change locally. Could you provide some guidance on how to do that or let me know if it's necessary? Please let me know if this fixes the issue and/or there's anything else I need to address. |
Looks correct to me. @OriolAbril ? |
It seems pre-commit still needs to be run with the latest changes. After that it should be good to go. Relevant section in the jupyter style guide: https://www.pymc.io/projects/docs/en/latest/contributing/jupyter_style.html#pre-commit-and-code-formatting. If the command there were to not work you can also try |
Thank you for merging this PR. I appreciate the guidance and patience. Looking forward to contributing more in the future! |
Thanks for your contribution @pradyutf !! 👍 |
Summary
This PR addresses the issue [#661]. It updates the link as suggested in the issue description.
Changes
Additional Notes
Please review and let me know if any further changes are needed or if there are any other links that need updating.
Thank you!
📚 Documentation preview 📚: https://pymc-examples--677.org.readthedocs.build/en/677/