Skip to content

Fix Broken Link in Weibull Accelerated Failure Time Model Notebook #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

pradyutf
Copy link
Contributor

@pradyutf pradyutf commented Jul 28, 2024

Summary

This PR addresses the issue [#661]. It updates the link as suggested in the issue description.

Changes

  • Updated the link in the .pynb file
  • Updated the link in the .md file

Additional Notes

Please review and let me know if any further changes are needed or if there are any other links that need updating.

Thank you!


📚 Documentation preview 📚: https://pymc-examples--677.org.readthedocs.build/en/677/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cluhmann
Copy link
Member

Thanks so much for opening this PR. Can you check out this section of the Jupyter style guide, because I think that's how the link needs to be fixed. If the notebook that needs to be linked to doesn't have the (notebook_name)= attribute, then I think that should be added to the target notebook first, and then the link can be updated in the Weibull notebook.

Let me know if that's unclear (it may be).

@pradyutf
Copy link
Contributor Author

Thanks so much for your guidance! I apologise for the oversight. I've now updated the link in the Weibull notebook using {ref} as suggested and added the required (bayes_param_survival_pymc3)= attribute to the target notebook.

I wasn't able to check this change locally. Could you provide some guidance on how to do that or let me know if it's necessary?

Please let me know if this fixes the issue and/or there's anything else I need to address.

@cluhmann
Copy link
Member

Looks correct to me. @OriolAbril ?

@cluhmann cluhmann requested a review from OriolAbril July 29, 2024 20:49
@OriolAbril
Copy link
Member

It seems pre-commit still needs to be run with the latest changes. After that it should be good to go.

Relevant section in the jupyter style guide: https://www.pymc.io/projects/docs/en/latest/contributing/jupyter_style.html#pre-commit-and-code-formatting. If the command there were to not work you can also try pre-commit run --all

@OriolAbril OriolAbril changed the title Fix Broken Link in Weibull Accelerated Failure Time Model Notebook [issue #661] Fix Broken Link in Weibull Accelerated Failure Time Model Notebook Jul 29, 2024
@OriolAbril OriolAbril linked an issue Jul 29, 2024 that may be closed by this pull request
@OriolAbril OriolAbril merged commit 65f4cd9 into pymc-devs:main Jul 29, 2024
2 checks passed
@pradyutf
Copy link
Contributor Author

Thank you for merging this PR. I appreciate the guidance and patience. Looking forward to contributing more in the future!

@cluhmann
Copy link
Member

Thanks for your contribution @pradyutf !! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in Weibull Accelerated Failure Time Model notebook
3 participants