Update HSGP with changes from PyMC #7342 #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB AlexAndorra commented on 2024-06-02T16:17:04Z Line #12. X_center = (np.max(X, axis=0) - np.min(X, axis=0)) / 2.0 IIUC, this is computing the radius, not the mid point. For the latter, I think, we need to change the formula to:
|
AlexAndorra
requested changes
Jun 2, 2024
There was a problem hiding this comment.
Thanks @bwengals ! I think there is a typo in the computation of X_center for the Gram matrix. Otherwise it looks all good!
AlexAndorra
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pm.gp.hsgp_approx.approx_hsgp_hyperparamsXsinput withXon.prior_linearized📚 Documentation preview 📚: https://pymc-examples--665.org.readthedocs.build/en/665/