Skip to content

Misc improvements to GP Latent NB #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Misc improvements to GP Latent NB #664

merged 1 commit into from
Jun 1, 2024

Conversation

AlexAndorra
Copy link
Collaborator

@AlexAndorra AlexAndorra commented May 27, 2024

Very straightforward changes. I'll auto-merge in a few days if nobody wants to review:

  • Actually used T-distributed noise for the first example (it was saying it was T noise, but it was actually normal noise)
  • Removed uutdated mention of theano and .eval() in the comments

📚 Documentation preview 📚: https://pymc-examples--664.org.readthedocs.build/en/664/

@AlexAndorra AlexAndorra self-assigned this May 27, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented May 27, 2024

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2024-05-27T16:08:41Z
----------------------------------------------------------------

Maybe also run 4 chains?


AlexAndorra commented on 2024-05-27T18:01:37Z
----------------------------------------------------------------

It takes a reaaaaaaally long time to run, so that's why I kept it to 2 chains

Copy link
Collaborator Author

It takes a reaaaaaaally long time to run, so that's why I kept it to 2 chains


View entire conversation on ReviewNB

@bwengals bwengals self-requested a review June 1, 2024 21:55
@bwengals bwengals merged commit 6b607f9 into main Jun 1, 2024
3 checks passed
@OriolAbril OriolAbril deleted the improve-gp-latent branch June 3, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants