-
-
Notifications
You must be signed in to change notification settings - Fork 269
Update GP Marginal and Latent notebooks to v5 #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the comments on the myst file, I can't add comments on lines in the notebook diff. But as per usual, the changes should be done to ipynb and then run pre-commit to have myst files updated automatically.
Ping @fonnesbeck |
Hi! |
@fonnesbeck I think you'll need to delete the branch and create it again. I tried to rebase and I had merge issues from some 2022 commits still in this branch. I think I manage to fix the issues anyway and will merge if checks pass |
Description
Updates to GP notebooks based on API changes in V5. Notably, using sampling everywhere instead of find_MAP, since sample_posterior_predictive no longer works properly with MAP estimates.
Helpful links