Skip to content

Update GP Marginal and Latent notebooks to v5 #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 13, 2023

Conversation

fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Jun 5, 2023

Description

Updates to GP notebooks based on API changes in V5. Notably, using sampling everywhere instead of find_MAP, since sample_posterior_predictive no longer works properly with MAP estimates.

Helpful links

@fonnesbeck fonnesbeck requested a review from bwengals June 5, 2023 19:15
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fonnesbeck fonnesbeck requested a review from OriolAbril June 5, 2023 19:15
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the comments on the myst file, I can't add comments on lines in the notebook diff. But as per usual, the changes should be done to ipynb and then run pre-commit to have myst files updated automatically.

@twiecki
Copy link
Member

twiecki commented Jul 11, 2023

Ping @fonnesbeck

@fonnesbeck
Copy link
Member Author

Hi!

@fonnesbeck fonnesbeck requested a review from OriolAbril July 11, 2023 15:00
@OriolAbril
Copy link
Member

@fonnesbeck I think you'll need to delete the branch and create it again. I tried to rebase and I had merge issues from some 2022 commits still in this branch. I think I manage to fix the issues anyway and will merge if checks pass

@OriolAbril OriolAbril merged commit dd98fe6 into pymc-devs:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants