Skip to content

notebook: Bayes Factor (run with pymc v5) #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2023

Conversation

reshamas
Copy link
Contributor

@reshamas reshamas commented Jan 4, 2023

Description

Run Bayes Factor notebook with PyMC version 5.

NOTE: needed to set progressbar=False to avoid errors.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -333,6 +333,7 @@ az.plot_bf(idata_conc, var_name="a", ref_val=0.5);
* Updated by Osvaldo Martin in August, 2018 ([pymc#3124](https://github.com/pymc-devs/pymc/pull/3124))
* Updated by Osvaldo Martin in May, 2022 ([pymc-examples#342](https://github.com/pymc-devs/pymc-examples/pull/342))
* Updated by Osvaldo Martin in Nov, 2022
* Updated: ran PyMC v5 in Jan, 2023
Copy link
Member

@OriolAbril OriolAbril Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add yourself here, and use re-executed according to what we agreed when we set this up: https://docs.pymc.io/en/latest/contributing/jupyter_style.html#authorship-and-attribution. the PR link can be skipped if you want

@reshamas reshamas requested a review from OriolAbril January 10, 2023 17:57
@cluhmann
Copy link
Member

Is there an issue open for the progressbar problem?

@reshamas
Copy link
Contributor Author

Is there an issue open for the progressbar problem?

No. @OriolAbril said it was specific to this notebook, not a general problem.

@OriolAbril
Copy link
Member

There is an issue: pymc-devs/pymc#5855 we already commented there, but it is not clear how to reproduce the issue so it hasn't been fixed.

@cluhmann
Copy link
Member

Got it. Just wanted to make sure it was being referenced here if the issue already existed. But now it is!

@OriolAbril
Copy link
Member

I have re-executed the notebook locally to see if I could reproduce the issue, but I didn't, in my case it worked, so the issue will continue to be open and with no solution in sight. I have pushed so we can merge without needing to remove the progressbar in sample_smc

@OriolAbril OriolAbril merged commit 9169216 into pymc-devs:main Jan 15, 2023
@reshamas reshamas changed the title notebook: Bayes Factor; run using pymc v5 notebook: Bayes Factor (run with pymc v5) Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants