-
-
Notifications
You must be signed in to change notification settings - Fork 269
Replace at -> pt. #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace at -> pt. #485
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
" at.as_tensor_variable(emission_noise),\n", | ||
" pt.as_tensor_variable(emission_observed),\n", | ||
" pt.as_tensor_variable(emission_signal),\n", | ||
" pt.as_tensor_variable(emission_noise),\n", | ||
" at.as_tensor_variable(logp_initial_state),\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably change (or remove) these lines in rerun.py
"from theano import tensor as tt": "import aesara.tensor as at",
"import theano.tensor as tt": "import aesara.tensor as at",
"theano": "aesara",
"Theano": "Aesara",
"tt.": "at.",
"aet": "at",
There's also this in
and this in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left minor comment, other than that looks good. But I have not gone through the replaces carefully, only skimming
@@ -234,6 +234,7 @@ def setup(app: Sphinx): | |||
"numpy": ("https://numpy.org/doc/stable/", None), | |||
"pandas": ("https://pandas.pydata.org/pandas-docs/stable/", None), | |||
"pymc": ("https://www.pymc.io/projects/docs/en/stable/", None), | |||
"pytensor": ("https://pytensor.readthedocs.io/en/latest/", None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove aesara from this dict and replace it with pytensor instead of adding pytensor. Same goes for the pre-commit config
Following #481, now also renaming at->pt. This is the script: