Skip to content

Correct definition of nu and assign lower value for sigma_low #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

hyosubkim
Copy link
Contributor

  • 1 should be added to nu_minus_one using pm.Deterministic, otherwise addition of 1 in old definition has no effect and hence probability was non-zero for values of nu that are less than one
  • Added definition and figure panel for log10(nu) to better align with Kruschke 2013
  • Lowered sigma_low value to 10^-1 because sigma values less than 1 are credible (as seen for Group 2 Std Dev in Fig 3 from Kruschke 2013)

With suggested changes, results will more closely align with Kruschke paper, which example is based on.

{Insert Description}

Helpful links

- 1 should be added to nu_minus_one using pm.Deterministic,
  otherwise addition of 1 in old definition has no effect
  and hence probability was non-zero for values of nu that
  are less than one
- Added definition and figure panel for log10(nu) to better
  align with Kruschke 2013
- Lowered sigma_low value to 10^-1 because sigma values less
  than 1 are credible (as seen for Group 2 Std Dev in Fig 3
  from Kruschke 2013)

With suggested changes, results will more closely align with
Kruschke paper, which example is based on.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriolAbril
Copy link
Member

Thanks, can you run pre-commit?

It should be something like:

pip install pre-commit # or conda or local install
pre-commit run --all

which should update the .myst.md file. Then commit and push and all checks should pass hopefully

@hyosubkim
Copy link
Contributor Author

I did as suggested and pushed the changes. Hope it went through okay this time.

@OriolAbril OriolAbril merged commit e4106d4 into pymc-devs:main Nov 15, 2022
@OriolAbril
Copy link
Member

Thanks! This got both CI jobs to pass

@hyosubkim
Copy link
Contributor Author

Great! Thanks again for your help

@hyosubkim hyosubkim deleted the my-feature branch November 15, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants