Skip to content

Add new tutorial on how to run pathfinder from pymc-experimental. #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 12, 2022

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Sep 30, 2022

Tutorial on how to run pathfinder VI

Helpful links

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@twiecki
Copy link
Member Author

twiecki commented Sep 30, 2022

Not sure why ci is failing. @OriolAbril any ideas?

@twiecki
Copy link
Member Author

twiecki commented Oct 5, 2022

I really can't figure this out, there's no reference to www.pymc.io.

@twiecki twiecki force-pushed the blackjax_pathfinder branch from db2090b to e571dc9 Compare October 11, 2022 10:43
@twiecki
Copy link
Member Author

twiecki commented Oct 11, 2022

Rebasing fixed it.

@drbenvincent drbenvincent self-requested a review October 11, 2022 12:25
@drbenvincent
Copy link
Contributor

Looks fine to me. But any changes required given the rename of the pymc-experimental repo? E.g in the import statement?

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the style and how concise and to the point the notebook is

@twiecki twiecki requested a review from OriolAbril October 11, 2022 16:54
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing the page footer thing that has the license info and citation advise: https://docs.pymc.io/en/latest/contributing/jupyter_style.html#epilogue, but looks great otherwise. Pre-emptively approving so you can merge after adding that.

@twiecki twiecki merged commit dce63a0 into main Oct 12, 2022
@twiecki twiecki deleted the blackjax_pathfinder branch October 12, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants