Skip to content

Notebook: sampler_stats; update links, clean up sections #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2022

Conversation

reshamas
Copy link
Contributor

References

Helpful links

Notes for the Reviewer

  • made some minor updates to the notebook, to be consistent with other notebooks and the style guide.

#DataUmbrellaPyMCSprint

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -7,11 +7,6 @@
"(sampler_stats)=\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a "keyword" way to reference/link to this bit of documentation?


Reply via ReviewNB

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This notebook is currently being excluded from pre-commit checks: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml#L71. One of the comments below fixes a reference that was a url to our own docs, but we should remove this from the exceptions and check there are no more urls that should be references

@@ -189,15 +186,19 @@ az.plot_density(
);
```

## Authors
* Moved from pymc to pymc-examples repo in December 2020 ([pymc-examples#8](https://github.com/pymc-devs/pymc-examples/pull/8))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not include this here

@OriolAbril
Copy link
Member

related to #46

@OriolAbril OriolAbril merged commit 5c07d60 into pymc-devs:main Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants