-
-
Notifications
You must be signed in to change notification settings - Fork 269
Upgrade notebook Gaussian Process to V4 #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Ana Rita Santos <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
We have 2 observations:
y_pred = [
np.random.multivariate_normal(m, S)
for m, S in zip(gp_trace.posterior["mu_post"].T, gp_trace.posterior["sigma_post"].T)
] We use
|
I am not very opinionated on this right now, but I will oppose changing the name if it comes up in the future. Currently most of the old links are broken (in the sense that they point to v3 docs, but using the version switcher ends up in a 404 page), so changing the name right now has very little effect. Once the updated |
I am not understanding the Read the Docs error message. It seems to be complaining about another notebooks. @OriolAbril ? |
Already commented above, but I'll add some extra info here for full context. The line right above the error message makes reference to a different notebook yes, but that is a sphinx warning, not an error. It is something that we should be aware of and try to fix it (it might become an actual error in a future version for example), but it is not breaking the doc build. The error references:
which means that what is breaking the doc build is something related to the post directive, it doesn't give specific information about what exactly in the post directive is breaking everything. That I am inferring/deducing from the bad format of the date in the post directive plus the |
Looks like I did not guess the cause of the readthedocs issue 😕 . Can you try adding |
I tested locally with ablog 0.10.26 and it worked, so let's see. I added the related issue in the comment. |
It looks like some of the updated versions (no idea what though) is breaking the thumbnail gallery: https://pymcio--404.org.readthedocs.build/projects/examples/en/404/gallery.html. This one seems to be the last working build for pymc-examples. For now, can you check the versions used there for sphinx and sphinx gallery and pin them? Then open an issue as a reminder to look into this and fix it. |
## Authors | ||
* Adapted from Stan's [example-models repository](https://github.com/stan-dev/example-models/blob/master/misc/gaussian-process/gp-fit.stan) by Chris Fonnesbeck in 2016 | ||
* Updated by Ana Rita Santos and Sandra Meneses in July, 2022 ([pymc#404](https://github.com/pymc-devs/pymc/pull/404)) | ||
|
||
```{code-cell} ipython3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a watermark title right above this cell: https://docs.pymc.io/en/latest/contributing/jupyter_style.html#watermark
The error in the gallery is still there 😭 . I updated the issue with some more details. |
I checked the preview and the gallery now and it seems to be working for me. Does it still happen for you after refreshing multiple times or trying a different browser? |
Niiice, it's working fine now. No need to cry 😉 |
* ⬆️ upgrade nb to V4 Co-authored-by: Ana Rita Santos <[email protected]> * 👌 updates due to review comments * 👌 sampling with multivariate_normal from xarray_einstats dev * 📌 set ablog version * 🍻 🐛 fix the pinning * 📌 pin sphinx and sphinx gallery * 📝 add watermark header Co-authored-by: Ana Rita Santos <[email protected]>
It solves #79
The number of particles
n_particles
was changed to 100 to get the notebook executed within an acceptable time.Thanks to @cluhmann @fonnesbeck for your help 🔥
Co-authored-by: @AnaRita93
#DataUmbrellaPyMCSprint
Gaussian Process notebook
Helpful links