Skip to content

update notebook rendering: Bayes Factor #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2022
Merged

update notebook rendering: Bayes Factor #395

merged 6 commits into from
Jul 20, 2022

Conversation

reshamas
Copy link
Contributor

@reshamas reshamas commented Jul 9, 2022

References

Towards #65
Towards #5460
References #394

Description

Added header and footer to the file similar to the Jupyter Style Guide.

#DataUmbrellaPyMCSprint

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@reshamas reshamas requested a review from aloctavodia July 9, 2022 17:42
@reshamas
Copy link
Contributor Author

reshamas commented Jul 9, 2022

@aloctavodia This notebook has you as the author, but I wasn't able to find you in the commit history. So, I wasn't sure which PR to add as a reference.

@OriolAbril
Copy link
Member

You need to add the section title to the cell with the authors, a level 2 markdown header.


Most notebooks were created and added to the pymc repo, if you want to find the PR adding it you'll need to search there. They were then moved here to reduce the size of the pymc repo and package. The updates to v4 (which this one has already had) have all been here and are easier to track, you can check the history of each notebook independently on github.

It is not necessary for you to track the history of the notebook, especially while on the pymc repo, what is a requirement of new PRs is to preserve any existing authorship mentions and make sure they follow the right formatting and adding your changes there too.

It is also recommended but not required for attribution bullet points to have a link to the PR if you don't know it, it is more important to keep authorship and attribution notes than to add the link


You will also need to run pre-commit to get CI to pass. All notebooks have two representations as raw text (myst) and as ipynb file which pre-commit makes sure they are synced

@aloctavodia
Copy link
Member

Hi @reshamas I am not able to find the original PR, it was a looong time ago. Also notice that there have been several updates to this notebook that are listed as the practice of consistenly adding a changelog to the notebook is relatively new. The last change to this notebook was this #342

@reshamas
Copy link
Contributor Author

@aloctavodia I was able to find the PRs:

The latest bottleneck to me moving this PR forward is this error:

pymc-projects/pymc-devs-repos/pymc-examples  nb_bayes_factor ✗                                         2d ⚑  
▶ sphinx-build examples/ _build -b html
Running Sphinx v4.2.0

Extension error:
Could not import extension myst_nb (exception: No module named 'myst_nb')
(talks) 

@reshamas
Copy link
Contributor Author

@aloctavodia Where would I find the pre-commit instructions?

You will also need to run pre-commit to get CI to pass. All notebooks have two representations as raw text (myst) and as ipynb file which pre-commit makes sure they are synced

@OriolAbril
Copy link
Member

If you followed the steps in https://pymc-data-umbrella.xyz/en/latest/sprint/tutorials/environment_setup.html#environment-setup and https://pymc-data-umbrella.xyz/en/latest/sprint/tutorials/pr_tutorial.html pre commit will run automatically when you commit. This can also be a bit slow at times, so it is also perfectly ok to run pre commit manually instead of this automatic approach. There is some guidance on that in the jupyter style guide https://www.pymc.io/projects/docs/en/latest/contributing/jupyter_style.html#pre-commit-and-code-formatting

@OriolAbril
Copy link
Member

The latest bottleneck to me moving this PR forward is this error:

To build the examples page locally (what sphinx build does) you need to install the requirements and run this sphinx build command. There are some more details at https://github.com/pymc-devs/pymc-examples/blob/main/CONTRIBUTING.md#contributor-guide. However, it is not necessary to use sphinx locally, you can rely on the readthedocs preview (in the checks below like on pymc.io)

Copy link
Member

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aloctavodia aloctavodia merged commit 49751c4 into pymc-devs:main Jul 20, 2022
@aloctavodia
Copy link
Member

Thanks @reshamas

@reshamas reshamas deleted the nb_bayes_factor branch July 20, 2022 17:06
@reshamas reshamas restored the nb_bayes_factor branch July 21, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants