Adapted code for survival_analysis.ipynb to work with v4 #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The code (new and old) has a very high number of divergences (>100). Would it be worth it to try to reduce that? Although the r_hat values look good, it seems that we shouldn't be encouraging analysis with this level of divergences? |
|
If you can do so but otherwise add a note with a disclaimer that this
amount of divergences would warrant further investigation. it's a good
teaching opportunity!
…On Sunday, June 5, 2022, Fernando Irarrázaval ***@***.***> wrote:
The code (new and old) has a very high number of divergences (>100). Would
it be worth it to try to reduce that? Although the r_hat values look good,
it seems that we shouldn't be encouraging analysis with this level of
divergences?
—
Reply to this email directly, view it on GitHub
<#372 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXBFYMNSJ6H347Q5U46JILVNUI4XANCNFSM5X5S5MPA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Makes sense! I think I will add a disclaimer since I don't know enough about these type of models to get rid of the divergences |
|
Sounds good, and if youd like open up an issue ticket as well so someone else can come by later and try their hand at reducing the divergences |
|
Thanks @cuchoi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates survival analysis notebook to v4. Issue #128.
Helpful links