Skip to content

Updated BNN notebook for v4 #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2022
Merged

Updated BNN notebook for v4 #337

merged 2 commits into from
May 31, 2022

Conversation

fonnesbeck
Copy link
Member

Second try updating BNN notebook after merge conflicts in original.

@fonnesbeck fonnesbeck requested a review from twiecki May 31, 2022 01:53
@twiecki
Copy link
Member

twiecki commented May 31, 2022

The pre-commit has a weird error, it might be to do with the myst file not being created? Does the pre-commit pass for you locally? Maybe @OriolAbril has an idea.

@twiecki
Copy link
Member

twiecki commented May 31, 2022

And why isn't reviewNB not showing up?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ghost
Copy link

ghost commented May 31, 2022

Added md file. Should work now.

Copy link
Member

@twiecki twiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fonnesbeck fonnesbeck merged commit 2cf0ccf into main May 31, 2022
@fonnesbeck fonnesbeck deleted the bnn_update2 branch May 31, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants