Skip to content

update SMC v4 #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2022
Merged

update SMC v4 #334

merged 3 commits into from
May 31, 2022

Conversation

aloctavodia
Copy link
Member

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ricardoV94
ricardoV94 reviewed May 30, 2022
View reviewed changes
examples/samplers/SMC2_gaussians.ipynb
@@ -7,7 +7,7 @@
"# Sequential Monte Carlo\n",
Copy link
Member

@ricardoV94 ricardoV94 May 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testval should be replaced by initval as the warning suggests

Seems like in sample SMC we should suppress the Potential warning when sampling from the prior to start the population...

Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testval replaced.

I tried to filter the warning, but then the progressbar does not progress :-(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to filter the warning, but then the progressbar does not progress :-

I mean internally in PyMC

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to catch the warning inside the initialize_population function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you do it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see this pymc-devs/pymc#5827

@aloctavodia aloctavodia merged commit ff0156d into main May 31, 2022
@aloctavodia aloctavodia deleted the SMC branch May 31, 2022 23:20
This was referenced Jun 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 left review comments

@twiecki twiecki twiecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloctavodia @twiecki @ricardoV94