Skip to content

[ENH] Add a pre-commit check to prevent urls pointing to pymc docs #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 22, 2022

Conversation

juanitorduz
Copy link
Collaborator

Fixes #292

I would support by solving this issue. However from the description I am not 100% the cope of which subfolders I need to add. I am taking the implementation from pymc-devs/pymc#5486 as suggested in the issue description.

Once I get some initial feedback I will keep working on this one :)

@juanitorduz juanitorduz changed the title initial try [ENH] Add a pre-commit check to prevent urls pointing to pymc docs Apr 14, 2022
@OriolAbril
Copy link
Member

Thanks! It should check all the files inside the examples/ folder except the conf.py file.

@juanitorduz
Copy link
Collaborator Author

juanitorduz commented Apr 15, 2022

@OriolAbril is cc4d58f enough or should add / remove websites from the entry: > specification?

@juanitorduz juanitorduz requested a review from OriolAbril April 16, 2022 18:44
@OriolAbril
Copy link
Member

Thanks! Can you check if any of the now temporarily excluded notebooks is also in the "Done" column of the tracker project? https://github.com/pymc-devs/pymc-examples/projects/1

@juanitorduz
Copy link
Collaborator Author

Out of the 13 tickets in the "Done" column I do not see any which is also in this exclusion list.

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of the 13 tickets in the "Done" column I do not see any which is also in this exclusion list.

Great, thanks for the PR, I think it is ready to merge

@OriolAbril OriolAbril merged commit e4019da into pymc-devs:main Apr 22, 2022
@juanitorduz juanitorduz deleted the fix/pre-commit_internal_links branch April 22, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pre-commit check to prevent urls pointing to pymc docs
2 participants