-
-
Notifications
You must be signed in to change notification settings - Fork 269
[ENH] Add a pre-commit check to prevent urls pointing to pymc docs #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add a pre-commit check to prevent urls pointing to pymc docs #311
Conversation
Thanks! It should check all the files inside the |
@OriolAbril is cc4d58f enough or should add / remove websites from the |
Thanks! Can you check if any of the now temporarily excluded notebooks is also in the "Done" column of the tracker project? https://github.com/pymc-devs/pymc-examples/projects/1 |
Out of the 13 tickets in the "Done" column I do not see any which is also in this exclusion list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of the 13 tickets in the "Done" column I do not see any which is also in this exclusion list.
Great, thanks for the PR, I think it is ready to merge
Fixes #292
I would support by solving this issue. However from the description I am not 100% the cope of which subfolders I need to add. I am taking the implementation from pymc-devs/pymc#5486 as suggested in the issue description.
Once I get some initial feedback I will keep working on this one :)