Skip to content

replace nbqa-black with black-jupyter #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Sep 9, 2021

Description

Replaces nbqa's hook with black's built-in support for Jupyter, as it'll be far better maintained

None of the modified notebooks are being modified by open PRs, should I think this should be OK to merge without it being disruptive

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@OriolAbril OriolAbril merged commit f48e7a6 into pymc-devs:main Sep 9, 2021
@MarcoGorelli MarcoGorelli deleted the black-jupyter branch September 9, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants