Skip to content

bump nbqa and pyupgrade #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2021
Merged

bump nbqa and pyupgrade #166

merged 1 commit into from
May 30, 2021

Conversation

MarcoGorelli
Copy link
Contributor

Description

Addresses issue #xxx and aims to advance it to

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@OriolAbril
Copy link
Member

This will generate git conflicts with a couple other PRs if merged as is. If someone has time it would be great to go over the changes here and comment those that affect notebooks that currently have an open PR there. Then merge this with only the non problematic changes. Maybe @chiral-carbon ? Maybe it's just me but I hate having git conflicts on notebooks

@MarcoGorelli
Copy link
Contributor Author

Maybe it's just me but I hate having git conflicts on notebooks

yeah same, they're an extra level worse than "regular" merge conflicts

Alternatively, could put off the pyupgrade bump for now and just upgrade nbqa as its handling of magics is now more stable and this risks causing less trouble to contributors

@OriolAbril OriolAbril merged commit 6a23dba into pymc-devs:main May 30, 2021
@MarcoGorelli MarcoGorelli deleted the bump-ci branch May 30, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @OriolAbril