Skip to content

update to Censored Data Models notebook #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

drbenvincent
Copy link
Contributor

Here are a few updates to the Censored Data Models notebook #126

  • Updated to best practice.
  • Corrected an error in that the data in the first figure was truncated instead of censored.
  • Added additional example to make it clearer that you get biased estimates using an uncensored model on censored data.
  • Updated the prior over mu in the models. Previous prior was causing systematic underestimates in mu

It would be good to put a link in to the notebook on truncated and censored regression #162, but that's not been merged so not sure what the final URL will be.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriolAbril
Copy link
Member

It would be good to put a link in to the notebook on truncated and censored regression #162, but that's not been merged so not sure what the final URL will be.

Can you comment that on the issue? We should probably find a way to use custom anchors for links instead of relying on the url. Therefore, if we reorgnize the examples or we update the base url (i.e. adding a /stable/ /3.11.2/ verision indicator)... we only need to regenerate the documentation instead of hunting down all urls

@drbenvincent
Copy link
Contributor Author

Can you comment that on the issue?

Done

@OriolAbril OriolAbril merged commit 2b4e2e1 into pymc-devs:main Jun 6, 2021
@drbenvincent drbenvincent deleted the censored_data_models branch June 7, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants