Update GLM-poisson-regression to best practices state

[chiral-carbon]

Addresses issue #86 and aims to advance it to best practices state.

General Updates

• Uses numpy.Generator
• Modifies cells 15 and 19 to compute exponent before calling az.summary

ArviZ Related

• Uses arg kind=stats rather than manually subsetting columns for stats in cells 15 and 19 to display summary

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2021-05-06T15:05:07Z
----------------------------------------------------------------

Can you add a note to the tracker issue for this notebook that this cell may benefit from https://github.com/arviz-devs/arviz/issues/1469? It is still a feature request and will be some time until it's done and released, so it makes no sense to pause the PR until this is finished, but it will be good to keep track of this I think

chiral-carbon commented on 2021-05-06T18:15:51Z
----------------------------------------------------------------

yes, sure. should I just comment under it and cite the Warning I get in this cell? asking because I'm a little unclear as to what exactly I should mention.

OriolAbril commented on 2021-05-06T21:41:23Z
----------------------------------------------------------------

yes, this is fine. Seeing the comment on the issue and looking at the notebook should be enough to link things up

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2021-05-06T15:05:08Z
----------------------------------------------------------------

xarray and theano need to be added here

chiral-carbon commented on 2021-05-06T17:40:28Z
----------------------------------------------------------------

right, will add

[OriolAbril]

Thanks for the PR, I think it can be merged after updating the watermark

[OriolAbril]

yes, this is fine. Seeing the comment on the issue and looking at the notebook should be enough to link things up

---

View entire conversation on ReviewNB