Skip to content

probabilistic matrix factorization #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
OriolAbril opened this issue Mar 29, 2021 · 5 comments
Open

probabilistic matrix factorization #58

OriolAbril opened this issue Mar 29, 2021 · 5 comments
Labels
tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/case_studies/probabilistic_matrix_factorization.ipynb
Reviewers: @ColCarroll

Known changes needed

Changes listed in this section should all be done at some point in order to get this
notebook to a "Best Practices" state. However, these are probably not enough!
Make sure to thoroughly review the notebook and search for other updates.

General updates

Changes for discussion

Changes listed in this section are up for discussion, these are ideas on how to improve
the notebook but may not have a clear implementation, or fix some know issue only partially.

ArviZ related

  • Use ArviZ and xarray for postprocessing. This will probably be challenging. I'd recommend familiarizing with xarray before working on that. Some ideas:
    • _norms in code cell 23 looks like it could be replaced by xr.apply_ufunc (using input_core_dims)

Notes

Exotic dependencies

None

Computing requirements

Model samples in roughly 1 hour
@OriolAbril OriolAbril added tracker id Issues used as trackers in the notebook update project, do not close! good first issue Good for newcomers labels Mar 29, 2021
@OriolAbril
Copy link
Member Author

Note: the "good first issue" label only applies to updating the notebook from To Do to General Updates.

@chiral-carbon
Copy link
Collaborator

Hi @OriolAbril , can I take this issue up? I am going through the probabilistic matrix factorization notebook at the moment and thought I could attempt to make the recommended changes.

@chiral-carbon chiral-carbon mentioned this issue Apr 18, 2021
Closed
@OriolAbril
Copy link
Member Author

Definitely, I'll assign it to you. Let me know if you have any doubts, especially on xarray which can be challenging even for seasoned pymc3 users

@chiral-carbon
Copy link
Collaborator

sure, thanks! I'll get back to you on this.

@chiral-carbon chiral-carbon mentioned this issue May 3, 2021
Merged
@OriolAbril OriolAbril removed the good first issue Good for newcomers label Jan 10, 2022
@percevalve
Copy link
Contributor

Looking into this one.

@percevalve percevalve mentioned this issue Jun 3, 2022
Merged
2 tasks
twiecki pushed a commit that referenced this issue Jan 17, 2023
@michaelosthege
Add pre-commit config and CI workflow (#58)
388b926 
* Add pre-commit config

Closes #39

* Apply pre-commit formatting
@twiecki twiecki moved this to Best practices (v3) in Notebook state tracker Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Notebook state tracker
Status: Best practices (v3)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@percevalve @OriolAbril @chiral-carbon