Skip to content

BEST #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OriolAbril opened this issue Mar 29, 2021 · 4 comments
Closed

BEST #52

OriolAbril opened this issue Mar 29, 2021 · 4 comments
Labels
high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/case_studies/BEST.ipynb
Reviewers: @twiecki @fonnesbeck

Context

Known changes needed

Changes listed in this section should all be done at some point in order to get this
notebook to a "Best Practices" state. However, these are probably not enough!
Make sure to thoroughly review the notebook and search for other updates.

General updates

Notes

Exotic dependencies

None

Computing requirements

Models sample in less than a minute

@OriolAbril OriolAbril added tracker id Issues used as trackers in the notebook update project, do not close! good first issue Good for newcomers labels Mar 29, 2021
@larryshamalama
Copy link
Member

Submitted a PR here!

@OriolAbril OriolAbril added high impact Notebooks with most visits on docs.pymc.io and removed good first issue Good for newcomers labels Apr 6, 2021
@asuagar
Copy link
Contributor

asuagar commented Jan 7, 2022

Hello @OriolAbril! I would like to try to update this notebook to PyMC 4. I have done BEST before using NumPyro. I have a dumb question about the graphical representation where ArviZ is not used. Can it be used seaborn or other graphical library?

@OriolAbril
Copy link
Member Author

Assigned it to you @asuagar, thanks for helping out!

I have a dumb question about the graphical representation where ArviZ is not used. Can it be used seaborn or other graphical library?

Other libraries can be used for plotting, in many cases ArviZ is not the right tool for the job. i.e. ArviZ is designed to explore bayesian model results, so preliminary exploratory analysis should generally use something else, then use ArviZ afterwards to analyze the posterior. Was that the question?

@asuagar
Copy link
Contributor

asuagar commented Jan 7, 2022

Yes, it was. It is now clear to me. After reading several notebooks, I thought that there was some kind of limitation to Matplotlib for exploratory data analysis. Thank you by your fast reply.

twiecki pushed a commit that referenced this issue Jan 17, 2022
* update BEST pymc-example to PyMC4 #52

- update to PyMC 4
- rename of greek variables spelling them
- add header
- update Autorhsip
- add License section

* update references.bib with refs of BEST notebook

* update BEST pymc-example to PyMC4 #52

- update to PyMC 4
- rename of greek variables spelling them
- add header
- update Autorhsip
- add License section
- use bib file for bibliography references

* Delete BEST.ipynb

* update references.bib with BEST example refs

* update BEST to PyMC4 following the reference style

* minor changes BEST example

* use of lowercase citekeys in references.bib

* use of lowercase citekeys in BEST case study
twiecki pushed a commit that referenced this issue Jan 17, 2023
* add spline basis

* refactor the spline utils

* fix spline initialization

* add docs

* add docs

* reference Adrian in Notes

* black

* refactor bspline basis calls

* add type errors explicit

* add custom eval points API

* test against eval_points api

* fix docstring

* fix docs

* fix exception condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Development

No branches or pull requests

3 participants