Skip to content

Require latest pylint and issue DeprecationWarning on Py2 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2018
Merged

Require latest pylint and issue DeprecationWarning on Py2 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77b9b73
Require pylint>=1.8. Fixes #97, fixes #53
atodorov Jan 18, 2018
7b1db3f
Issue DeprecationWarning when running on Python 2
atodorov Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Version 0.8.0 (unreleased)

* This is the last version to support Python 2. Issues a deprecation warning!
* [#109](http://github.com/landscapeio/pylint-django/pull/109),
adding 'urlpatterns', 'register', 'app_name' to good names. Obsoletes
[#111](http://github.com/landscapeio/pylint-django/pull/111), fixes
Expand All @@ -23,7 +24,9 @@
Add support for django.contrib.postgres.fields and UUIDField (Villiers Strauss)
* Stop testing with older Django versions. Currently testing with Django 1.11.x and 2.0
* Stop testing on Python 2, no functional changes in the source code though
* Update tests for latest version of pylint (>=1.8)
* Update tests and require latest version of pylint (>=1.8), fixes
[#53](https://github.com/landscapeio/pylint-django/issues/53),
[#97](https://github.com/landscapeio/pylint-django/issues/97)

## Version 0.7.4
* [#88](https://github.com/landscapeio/pylint-django/pull/88) Fixed builds with Django 1.10 (thanks to [federicobond](https://github.com/federicobond))
Expand Down
8 changes: 8 additions & 0 deletions pylint_django/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
"""pylint_django module."""
from __future__ import absolute_import

import sys
import warnings

from pylint_django import plugin

if sys.version_info < (3, ):
warnings.warn("Version 0.8.0 is the last to support Python 2. "
"Please migrate to Python 3!", DeprecationWarning)

register = plugin.register
15 changes: 2 additions & 13 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,11 @@


_install_requires = [
'pylint-plugin-utils>=0.2.1'
'pylint-plugin-utils>=0.2.1',
'pylint>=1.8'
]


if sys.version_info < (2, 7):
# pylint 1.4 dropped support for Python 2.6
_install_requires += [
'pylint>=1.0,<1.4',
'astroid>=1.0,<1.3.0',
'logilab-common>=0.60.0,<0.63',
]
else:
_install_requires += [
'pylint>=1.0',
]

setup(
name='pylint-django',
url='https://github.com/landscapeio/pylint-django',
Expand Down