-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Include .c files in repo. #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't want to include the .c files in the repo because of the diff noise. @minrk do you know what could be wrong? |
I might. @twiecki - do you have vanilla setuptools or distribute? I encountered this or similar in pyzmq, where old-style setuptools will actually explicitly convert all your I can confirm on my system that a virtualenv created with setuptools cannot run the install above, but one with distribute instead can, so it's probably the same issue. |
@minrk Yes, it's in a virtualenv. Not sure what it was created with (used virtualenvwrapper), it might have both actually. |
Try this, then:
|
(if it works, I'll do a PR) |
@minrk: yes, that did the trick cythoning pandas/src/generated.pyx to pandas/src/generated.c Thanks! On Thu, Aug 23, 2012 at 2:34 PM, Min RK [email protected] wrote:
|
setuptools (not distribute) will replace '.pyx' extensions with '.c' if *pyrex* is not importable. This checks if that happened, and reverses it if so. closes pandas-dev#1805
See #1806 |
pip install git+https://github.com/pydata/pandas.git
does currently not work because the .pyx files are not being cythonized (not sure why). An easy fix is to include .c files in the git repo which should make it easier for people to deploy.
I used a simple try: import cython in setup.py that cythonizes if cython is installed and uses the .c files otherwise:
https://github.com/hddm-devs/hddm/blob/develop/setup.py#L4
The text was updated successfully, but these errors were encountered: