Skip to content

BUG: Correct behavior of yahoo #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage changed the title Galashour master BUG: Correct behavior of yahoo Jul 12, 2021
@bashtage
Copy link
Contributor Author

Extends #867 with bug fixes

Allow headers to be overridden
Set default behavior when user passes a session
@bashtage bashtage merged commit b56ca89 into pydata:main Jul 12, 2021
@bashtage bashtage deleted the galashour-master branch July 12, 2021 17:07
}
if headers is not None:
self.headers = headers
elif session is None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@bashtage bashtage added this to the 0.10 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_get_response without headers doesn't work (at least with 'yahoo' source
3 participants