-
Notifications
You must be signed in to change notification settings - Fork 679
Adds support for Enigma datasets #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @trevorprater Could you add A simple test will be nice also.
|
|
||
|
||
def _request(self, url): | ||
resp = requests.get(url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use
resp = self.session.get(url)
so query can be cached.
Thank you for the code review, @femtotrader! I have made the suggested changes. The only thing left is for me to write some tests, I think. |
Tests have been added and I believe all requested changes have been made. Thank you, @femtotrader! |
Thanks @trevorprater but I noticed you add directly API key Please also squash commits I suggest a commit message like "ENH: Adds support for Enigma datasets" |
df8ad82
to
c7c496c
Compare
Thank you for the additional feedback, @femtotrader. I have added the support for an environment variable I have also squashed the commits and updated the commit message. Trevor |
Thanks again @trevorprater Other contributions are welcome! |
I think it never succeeded on Travis because we don't set |
i just turned on the check that requires travis passing before merging |
I've prepared #250 to fix other broken tests. For this PR, we should decide either:
|
I'm for |
How about:
|
#250 is merged. I don't understand what you would like in tests ?
_exception or is something else required ? What can be the side effects of using |
What I meant is to make Enigma tests be runnable on Travis to guarantee the function. Currently no others run its tests, correct? |
Usage:
If
ENIGMA_API_KEY
does not exist in your env, it can be supplied as the second arg: