Skip to content

Drop wheel from build requirements; no longer needed as of setuptools 70.1 #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Apr 16, 2025

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The wheel readme says:

This project used to contain the implementation of the setuptools bdist_wheel command, but as of setuptools v70.1, it no longer needs wheel installed for that to work. Thus, you should install this only if you intend to use the wheel command line tool!

So if we upgrade our minimum setuptools to 70.1, we don't need to list wheel in pyproject.toml anymore.

setuptools 70.1.0 brought in the `bdist_wheel` command from `wheel`: https://setuptools.pypa.io/en/stable/history.html#v70-1-0
@kandersolar kandersolar added this to the v0.12.1 milestone Apr 16, 2025
@kandersolar kandersolar marked this pull request as ready for review April 16, 2025 14:47
@kandersolar kandersolar requested a review from echedey-ls April 16, 2025 15:02
Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward LGTM. No other significant occurrences of wheel in the project and build process works flawlessly. Well done on reviewing the build process :)

@kandersolar kandersolar merged commit 3f43a52 into pvlib:main Apr 17, 2025
30 checks passed
@kandersolar kandersolar deleted the nowheel branch April 17, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants