-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding PVGIS horizon data retrieval method #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 83 commits
Commits
Show all changes
102 commits
Select commit
Hold shift + click to select a range
539bc5c
added horizon model first draft
85754b5
added get horizon function
4985e9c
fixing stickler items & updates
132ab4e
stickler whitespace
64bbc97
finishing up stickler
19e1073
finishing up stickler, 2
d563a81
added optional deps, changed argument of horizon_map from path to array
e9856da
stickler
c392e29
Update pvlib/iotools/pvgis.py
bgpierc e8d6100
Update pvlib/horizon.py
bgpierc 3dca8bb
Update pvlib/horizon.py
bgpierc 93d914d
Update pvlib/horizon.py
bgpierc 5c1bc2d
Update pvlib/horizon.py
bgpierc eb8f8c5
Update pvlib/horizon.py
bgpierc 5a3c9cc
Update pvlib/horizon.py
bgpierc 515ed85
Update pvlib/horizon.py
bgpierc 1c3a398
Update pvlib/horizon.py
bgpierc a191d2d
Update pvlib/horizon.py
bgpierc 82ba2a5
Update pvlib/horizon.py
bgpierc ca2eec3
Update pvlib/horizon.py
bgpierc 996b3f9
Update pvlib/horizon.py
bgpierc 3717186
Update pvlib/horizon.py
bgpierc f9a2193
Update pvlib/horizon.py
bgpierc 989b700
updates
02082ee
cleaning up stickler
206f979
cleaning up stickler 2
156e964
cleaning up stickler 3
c674bb5
updated math for angle calculation
3a2cab9
removed old comment
78f6c1d
updated angle maximization method
641bf53
one of these days I'll remember stickler before pushing
3d310c6
changed variable names to make clear that we're working in pixels
c7b65b3
added module to download SRTM DEM data
288390b
spelling/spacing
e8d8795
stickler
a2496e5
stickler3
d36c508
fixed f string formatting
bgpierc 60ba9cb
added horizon retrival, functions, dem retrival
7b9d528
Merge branch 'master' into add_horizon
bgpierc 709493e
stickler
fa14c67
stickler2
97ee479
stickler3
43951a2
merge
6f9ad5e
merge2
8e01b57
Revert "merge2"
7b99b8d
fix formatting
9ea61e2
fix formatting, 2
e23d58c
removing horizon.py
801f4d3
tests added
860f484
Merge branch 'pvlib:main' into add_horizon
bgpierc bcca59b
updated test
6cfb0c4
fixed stickler
d5cd1af
minor formatting/stickler
53d9e6c
Update v0.9.6.rst
bgpierc c831107
Update iotools.rst
bgpierc 17e4f92
Apply suggestions from code review
bgpierc c176d9b
Change assert to use np builtin
bgpierc 0d2a061
correct docstring for hidden function
bgpierc 6980a4d
Chnage proxy settings to passing through kwargs
bgpierc cf21974
Changed proxy settings to pass kwargs
bgpierc 0fb9e05
Change assertion to use assert_series_equal from conftest
bgpierc 7736e35
Added horizon profile contributions
bgpierc 7f84531
Update v0.9.6.rst
bgpierc cb7eb41
Delete cgiar.py
bgpierc 25baf2b
Delete test_cgiar.py
bgpierc b9edf25
Update shading.py
bgpierc d15c7ff
Update setup.py
bgpierc 2bf5cb2
Update __init__.py
bgpierc 89e53d9
Update iotools.rst
bgpierc e13e322
Update test_pvgis.py
bgpierc 50e79cd
return only two columns and makde bytes->utf-8 implicit
bgpierc 75a9407
Use JSON to streamline processing
bgpierc d860570
Update pvgis.py
bgpierc 8aedbe6
added url default info
bgpierc 62237e2
Merge branch 'main' into add_horizon
bgpierc bef7c81
remove np dependency
bgpierc d9689d3
Apply suggestions from code review
bgpierc 302abb0
Moved ref for consistency
bgpierc 4ad491b
Updated name of horizon data variable
bgpierc 7901797
Add CSV for horizon tests
bgpierc af8988f
Test whole dataframe
bgpierc f58f8d7
Change coordinate system to pvlib
bgpierc a305ab6
fix test to read in csv properly
bgpierc 15e5c9c
Apply suggestions from code review
bgpierc 482bc23
Changed names for consistency
bgpierc 94fee4c
Match column names in test dataframe
bgpierc a8c7693
Merge branch 'main' into add_horizon
bgpierc 2eea384
stickler
bgpierc bf34256
Set horizon_azimuth to the index
bgpierc 01893d8
Added invalid coords test
bgpierc d978b2c
update test to reflect change to index
bgpierc b693813
forgot xfail flag
bgpierc 8de2506
Update test_read_pvgis_horzion_invalid_coords
AdamRJensen 6425884
Merge branch 'main' into add_horizon
bgpierc 568c9cd
return metadata object
bgpierc fb3d571
Update pvgis.py
bgpierc d3bc17b
fix tests for metadata update
bgpierc ec52f59
Merge branch 'main' into add_horizon
AdamRJensen a696faf
Remove index column from test file
AdamRJensen b65d58b
Convert output to pd.Series
AdamRJensen d008dab
Update tests to assert pd.Series
AdamRJensen 22e0988
Remove duplicate north value (0, 360)
AdamRJensen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
,horizon_azimuth,horizon_angles | ||
0,0.0,9.9 | ||
1,7.5,13.0 | ||
2,15.0,14.5 | ||
3,22.5,15.7 | ||
4,30.0,14.9 | ||
5,37.5,15.3 | ||
6,45.0,15.7 | ||
7,52.5,15.7 | ||
8,60.0,13.0 | ||
9,67.5,11.5 | ||
10,75.0,11.1 | ||
11,82.5,11.5 | ||
12,90.0,10.3 | ||
13,97.5,11.5 | ||
14,105.0,10.3 | ||
15,112.5,9.5 | ||
16,120.0,10.7 | ||
17,127.5,11.8 | ||
18,135.0,11.8 | ||
19,142.5,8.8 | ||
20,150.0,8.4 | ||
21,157.5,7.3 | ||
22,165.0,5.7 | ||
23,172.5,5.7 | ||
24,180.0,4.6 | ||
25,187.5,3.4 | ||
26,195.0,0.8 | ||
27,202.5,0.0 | ||
28,210.0,0.0 | ||
29,217.5,0.0 | ||
30,225.0,0.0 | ||
31,232.5,0.0 | ||
32,240.0,0.0 | ||
33,247.5,0.0 | ||
34,255.0,0.0 | ||
35,262.5,0.0 | ||
36,270.0,0.0 | ||
37,277.5,0.0 | ||
38,285.0,0.0 | ||
39,292.5,0.0 | ||
40,300.0,0.0 | ||
41,307.5,0.0 | ||
42,315.0,1.1 | ||
43,322.5,1.9 | ||
44,330.0,3.8 | ||
45,337.5,5.0 | ||
46,345.0,6.5 | ||
47,352.5,9.2 | ||
48,360.0,9.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.