Skip to content

Move test protos into protos directory #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

dibenede
Copy link
Contributor

@dibenede dibenede commented Sep 6, 2022

Tidying up the top-level directory by moving test protos into their own directory. Attempted to mirror the same folder structure for the commonjs tests for consistency.

@dibenede dibenede requested review from lukesandberg and removed request for lukesandberg September 6, 2022 16:23
@lukesandberg
Copy link
Contributor

What do you think of moving all the tests into a tests/ directory and putting the protos directory under that

@dibenede
Copy link
Contributor Author

dibenede commented Sep 6, 2022

Works for me. I'll move it over.

Copy link
Contributor

@lukesandberg lukesandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do more file moves in a followup

@dibenede dibenede merged commit 37c293c into protocolbuffers:main Sep 7, 2022
@dibenede dibenede deleted the move-tests branch September 7, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants